3805 partial cleaning up partner profile #5424
3805 partial cleaning up partner profile #5424janeewheatley merged 5 commits intorubyforgood:mainfrom
Conversation
cleaning up partner profile
cielf
changed the title
There was a problem hiding this comment.
@cielf After reviewing with core team, we ran the code locally and after the migration we noticed that the annotations were removed in our diffs. We believe the db annotations should not be added here. Please take a look.
There was a problem hiding this comment.
I think I put it before the migration, and that's what got pushed. Have run the migration and pushed those changes.
There was a problem hiding this comment.
@cielf I just ran a migration again and noticed that the include_packages_in_distribution_export seems to be removed in the diff, but I see it was added in your code. Just checking in on this:
There was a problem hiding this comment.
The only things that should change in the models are things that you explicitly added or removed. (per @awwaiid )
There was a problem hiding this comment.
I don't disagree -- the question is why we are getting different results?!
There was a problem hiding this comment.
@awwaiid -- I'm not sure how the whole updating-the-comments thing works -- To get the current version I grabbed the last version of this PR, ran a migration against production data, then pushed the resultant code. I don't know why @janeewheatley is getting a different result. Thoughts?
There was a problem hiding this comment.
Either that column should be there or it shouldn't. If it should, the comment should be there, and if it shouldn't, it should be removed.
There was a problem hiding this comment.
It looks to me like it was added in late November. #5408
There was a problem hiding this comment.
@janeewheatley
I ran the following sequence:
switch to main (from 3 days ago)
bin/setup (so I have the old db)
switch to this branch
rails db:migrate
and the field is there in the comments on organization as I would expect.
I could see the field being added if you were working from branch that branched off awhile ago, but I am stumped as to how it would have been removed.
There was a problem hiding this comment.
Confirmed that you are correct and this is a valid change.
|
@cielf: Your PR |
4 participants
Description
cleaning up partner profile (removing no-longer-used fields)
Partial solution for #3805
Cleaning up unused fields on partner profile only
From 3805, there was one field not in the db,
There were 3 additional fields that were in the "ignore columns" in profile.db. I have removed them as well. More details on the issue.
Other things you should know about
I didn't do the user fix yet, because a field I expect to be removable has recent data in it -- so there's a need to look further first.
Type of change
How Has This Been Tested?
Light functional testing of partner profile from bank's pov.
Currently having some issues with automated tests on my local, so using the ci here to check that.